Add complex support and test #1439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!tensor.is_xpu() || tensor.is_sparse() || tensor.is_complex()) { | ||
| C10_THROW_ERROR( | ||
| ValueError, "Tensors must be XPU and dense and non-complex"); | ||
| if (!tensor.is_xpu() || tensor.is_sparse()) { |
There was a problem hiding this comment.
If you remove this condition, then all collectives will by default support complex. Does it make sense for oneCCL right now?
There was a problem hiding this comment.
No, all tensor entre getXcclDataTypewill check tensor is_complex. If we confirm op support for complex types, we will convert them to real before calling getXcclDataType. Otherwise, an error will be raised within getXcclDataType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables XCCL to support complex data types for certain operations (
allreduce,reduce,broadcast). Since oneCCL does not support complex data types, the values are converted to real numbers before calling the oneCCL API. The implementation method and supported data types are fully aligned with NCCL.